Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

M41 version #245

Merged

Conversation

gemguardian
Copy link

@gemguardian gemguardian commented Feb 29, 2024

@jleyva as discussed in issue #241

enclosed you find our merge request for M4.1 - below you find the changes and to do's
It's been tested by various community members, and I have not received any input that makes me think it breaks things.

It would be great for the community if you can review the code and when you agree push this version to Moodle.org plugin database.

As said - we will not continue maintaining the plugin. If issues appear we suggest that people from the community send in their own fixes. or contact us to fix this for them against a fee.

4.1.0 (2023120600) for Moodle 4.1
Release date: 06.12.2023

This release focuses on solving issues in Moodle 4.1 and PHP 7.4 and start with small improvements and bug fixes.

Thanks to Lesterhuis Training & Consultancy for the contribution / updated by Ldesign Media

  • TODOS for the future:
    • Namespaces for classes & autoloading
    • Move all to classes to classes/ directory
    • Clean up code
    • Add tests
    • AJAX_SCRIPT move to webservice
    • unserialize() to json_decode()
    • Readme to Markdown format
    • validation if a class exists and inherits the correct parent class.
    • Changelog to separate file
    • Move cron to a scheduled task
    • phpcpd and phpdocs checks in CI
    • Make CSS strict should only affect this plugin

@jleyva jleyva changed the base branch from MOODLE_36_STABLE to MOODLE_401_STABLE May 6, 2024 08:00
@jleyva jleyva merged commit 44a2f36 into jleyva:MOODLE_401_STABLE May 6, 2024
@jleyva
Copy link
Owner

jleyva commented May 6, 2024

I am integrating this just after a very quick review (considering the amount of changes)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants