Fix default retry backoff factor #53
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updated RoboBrowser class to default to a retry multiplier of 0 instead of None. Previously when set to None a TypeError would be raised in the get_backoff_time method of urllib3's Retry class. [Resolves jmcarp#51]
rcutmore
force-pushed
the
fix-default-retry-backoff-factor
branch
from
dc7e97b
to
944c962
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #51 by changing the default multiplier in the RoboBrowser class. Previously this was set to None and would raise an error in the underlying urllib3 Retry class when calculating the backoff time for retries. I changed the default to 0 which matches the default in urllib3.