Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix button in form issue #56

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

fkztw
Copy link

@fkztw fkztw commented Nov 18, 2015

Support <button> tags in <form> .

shunyi added 2 commits November 18, 2015 12:37
<button> can be added into <form>.
Add this new feature so robobrowser can deal with <button> tags in
<form>
@gled-rs
Copy link

gled-rs commented Feb 29, 2016

+1 on this PR

According to <https://developer.mozilla.org/nl/docs/Web/HTML/Element/button>:

+ The type of the button. Possible values are:
    + submit: The button submits the form data to the server.
        + This is the default if the attribute is not specified, or if the attribute is dynamically changed to an empty or invalid value.
    + reset: The button resets all the controls to their initial values.
    + button: The button has no default behavior. It can have client-side scripts associated with the element's events, which are triggered when the events occur.
    + menu: The button opens a popup menu defined via its designated <menu> element.

So, we can treat the button tag with no type specifed as a submit tag.

Thanks Vincent Wagelaar <[email protected]> emailing me about this patch.
@fkztw
Copy link
Author

fkztw commented Nov 6, 2016

flake8 no longer supports Python 2.6 since flake8-3.0.0.

https://gitlab.com/pycqa/flake8/issues/187
http://flake8.pycqa.org/en/latest/release-notes/3.0.0.html

flake8 no longer supports Python 2.6 since flake8-3.0.0.
@JoabMendes
Copy link

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants