enable Playlists for oauth login flow #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Several places use the `backend.auth` flag to check if we're logged in or not. Since the API responds simlarly whether using the OAuth login or the old cookie login, this unifies those checks back under the `backend.auth` flag. To simplify setting it the flag, and since `_ytmusicapi_oauth_json` was only used for one function, I replaced it with direct references to the original `config['ytmusic']['oauth_json']`. Finally, checking before reading from `config` avoids crashes when only one or the other of `auth_json` or `oauth_json` is present in the config file
cprn
reviewed
Dec 29, 2024
| self._ytmusicapi_auth_json = config["ytmusic"]["auth_json"] | ||
| if "oauth_json" in config["ytmusic"]: | ||
| self.api = YTMusic(auth=config["ytmusic"]["oauth_json"]) | ||
| self.auth = True |
There was a problem hiding this comment.
When I was proposing my changes to use the newer authorisation method, I didn't want to overwrite user files, so I added a separate oauth_json section to the config and left auth_json intact. Later on it made me misread self.auth variable as "authorising through browser", I think, so I added a separate self.oauth for "authorising through OAuth API". Nowadays, I think the original intention for self.auth was to have a boolean equal to True whenever the app is authorised, regardless of how it was authorised. If I knew other devs will have to deal with my changes, I'd just overwrite the damn user file. 😆
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously user playlists were only loaded for the old cookie authentication. All that needed to be changed was one conditional.