Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pr261 using File::Path::Tiny #303

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

shawnlaffan
Copy link

This adds two commits to those in PR #261 to use File::Path::Tiny to remove the temp files. They are also rebased on current main.

Passes the tests added by @f20

An alternate approach would be to use File::Find to list all the files under the temp dir, sorted by depth, and then delete them using unlink.

There are two new warnings related to tainting. I'm not sure how important they are.

t/regression/taint01.t ................................ 1/1     (in cleanup) Insecure dependency in unlink while running with -T switch at C:/perls/5.40.0.1_PDL/perl/site/lib/File/Path/Tiny.pm line 74.
t/regression/taint01.t ................................ ok
t/regression/taint02.t ................................ 1/1     (in cleanup) Insecure dependency in unlink while running with -T switch at C:/perls/5.40.0.1_PDL/perl/site/lib/File/Path/Tiny.pm line 74.
t/regression/taint02.t ................................ ok

As a side note, I wonder if the temp dirs should have a prefix such as ewxlsx so they are easier to identify on the temp dir. I can add that if it is considered useful, or open a separate PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants