Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ability to custom insertion in Params #18

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

DmitryHudrich
Copy link

This commit introduces a custom method for inserting parameters into PHP-FPM requests. This was necessary because the general methods for parameter insertion might not include required parameters, such as HTTP_HOST, which is crucial for WordPress to function properly. The custom approach ensures that all necessary parameters are provided for correct operation.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
This commit introduces a custom method for inserting parameters into PHP-FPM requests. This was necessary because the general methods for parameter insertion might not include required parameters, such as HTTP_HOST, which is crucial for WordPress to function properly. The custom approach ensures that all necessary parameters are provided for correct operation.
@jmjoy
Copy link
Owner

jmjoy commented Jan 4, 2025

But Params implement DerefMut of HashMap, so you can use insert mehtod Inherited from HashMap.

@DmitryHudrich
Copy link
Author

Oh, sorry for my carelessness. insert works. But DerefMut requires a mutable variable. I think this is a bit inconsistent with the fact that the parameters are specified through a Builder.

@jmjoy
Copy link
Owner

jmjoy commented Jan 6, 2025

What's wrong with mutable variables?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants