Skip to content

Commit

Permalink
bump compatibility to include modern railses
Browse files Browse the repository at this point in the history
  • Loading branch information
jmmastey committed Apr 8, 2021
1 parent 0980688 commit 1eb3e65
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 11 deletions.
11 changes: 3 additions & 8 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -45,20 +45,15 @@ You'll also get a summary at the end of your test run:

![Test summary.](https://github.com/jmmastey/rspec-activerecord-formatter/raw/master/doc/images/demo_1.png "Test summary.")

The formatter will spit out a report with more data at the end of your run:


If you want less granularity, you can also use the progress formatter:

--require rspec-activerecord-formatter
--require rails_helper
--format ActiveRecordProgressFormatter

Next Steps
------------
* The method I was using to count AR objects doesn't work well with DatabaseCleaner when not explicitly wiring the library into `before` blocks.
I'd like to be able to go back to a method other than scanning for `INSERT INTO` strings.
* Configuration, especially formatting the output to optionally outdent the counts.
* The current dependency versions are a vague guess. They can and should clearly be more lenient.
* I dunno, tests.

Contributing
------------

Expand Down
5 changes: 2 additions & 3 deletions rspec-activerecord-formatter.gemspec
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ $LOAD_PATH << lib_dir unless $LOAD_PATH.include?(lib_dir)
Gem::Specification.new do |gem|

gem.name = "rspec-activerecord-formatter"
gem.version = "2.1.1"
gem.version = "2.2.0"

gem.summary = "Adds object creations and queries to Rspec output."
gem.description = "Creates a new formatter for ActiveRecord that can help you diagnose performance issues in RSpec"
Expand All @@ -25,9 +25,8 @@ Gem::Specification.new do |gem|

gem.require_paths = %w[ext lib].select { |dir| File.directory?(dir) }

# TODO: these are almost certainly too restrictive looking backward
gem.add_dependency "activesupport", ">= 4.0", "< 7.0"
gem.add_dependency "rspec", "~> 3.4"
gem.add_dependency "rspec", ">= 3.4"

gem.add_development_dependency "coveralls", "~> 0.8"
end

0 comments on commit 1eb3e65

Please sign in to comment.