Skip to content

Commit

Permalink
disabled loading cached libraries to better support customized primit…
Browse files Browse the repository at this point in the history
…ives
  • Loading branch information
jmoenig committed Jul 18, 2024
1 parent d70cfd7 commit 4360df6
Show file tree
Hide file tree
Showing 3 changed files with 13 additions and 3 deletions.
3 changes: 3 additions & 0 deletions HISTORY.md
Original file line number Diff line number Diff line change
Expand Up @@ -122,6 +122,9 @@
* **Translation Updates:**
* German

### 2024-07-18
* gui: disabled loading cached libraries to better support customized primitives

### 2024-07-17
* store: incremented app version to rc
* extensions: added "www" url prefix variant to birdbrain's extension entry
Expand Down
2 changes: 1 addition & 1 deletion snap.html
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@
<script src="src/threads.js?version=2024-06-10"></script>
<script src="src/objects.js?version=2024-07-11"></script>
<script src="src/scenes.js?version=2024-05-28"></script>
<script src="src/gui.js?version=2024-07-17"></script>
<script src="src/gui.js?version=2024-07-18"></script>
<script src="src/paint.js?version=2023-05-24"></script>
<script src="src/lists.js?version=2024-04-08"></script>
<script src="src/byob.js?version=2024-06-12"></script>
Expand Down
11 changes: 9 additions & 2 deletions src/gui.js
Original file line number Diff line number Diff line change
Expand Up @@ -87,7 +87,7 @@ BlockVisibilityDialogMorph, ThreadManager, isString, SnapExtensions, snapEquals

// Global stuff ////////////////////////////////////////////////////////

modules.gui = '2024-July-17';
modules.gui = '2024-July-18';

// Declarations

Expand Down Expand Up @@ -10473,6 +10473,7 @@ LibraryImportDialogMorph.prototype.importLibrary = function () {
// restore captured user-blocks categories
SpriteMorph.prototype.customCategories = this.originalCategories;

/*
if (this.hasCached(selectedLibrary)) {
this.cachedLibrary(selectedLibrary).forEach(def => {
def.receiver = ide.stage;
Expand All @@ -10484,6 +10485,11 @@ LibraryImportDialogMorph.prototype.importLibrary = function () {
);
ide.showMessage(`${localize('Imported')} ${libraryName}`, 2);
} else {
*/

// disabled loading cached libraries to better support customized
// primitives. -jens

ide.showMessage(`${localize('Loading')} ${libraryName}`);
ide.getURL(
ide.resourceURL('libraries', selectedLibrary),
Expand All @@ -10492,7 +10498,8 @@ LibraryImportDialogMorph.prototype.importLibrary = function () {
this.isLoadingLibrary = true;
}
);
}

// }
};

LibraryImportDialogMorph.prototype.displayBlocks = function (libraryKey) {
Expand Down

0 comments on commit 4360df6

Please sign in to comment.