Merge pull request #3300 from bromagosa/noExitWarning-option

add noExitWarning to IDE config options
jmoenig · Feb 12, 2024 · 6a962a7 · 6a962a7
2 parents a1f95cd + 98aa9f3
commit 6a962a7
Show file tree

Hide file tree

Showing 3 changed files with 11 additions and 1 deletion.
diff --git a/docs/API.md b/docs/API.md
@@ -130,6 +130,7 @@ You can configure the looks and behavior of the IDE by passing it a configuratio
 |noRingify:	|bool	|disable/enable "ringify" / "unringify" in context menus|
 |noUserSettings:	|bool	|disable/enable persistent user preferences|
 |noDevWarning:	|bool	|ignore development version incompatibility warning|
+|noExitWarning:	|bool	|do not show a browser warning when closing the IDE with unsaved changes|
 |blocksZoom:	|num	|zoom factor for blocks, e.g. `1.5`|
 |blocksFade:	|num	|fading percentage for blocks, e.g. `85`|
 |zebra:	|num	|contrast percentage for nesting same-color blocks|

diff --git a/src/gui.js b/src/gui.js
@@ -420,7 +420,7 @@ IDE_Morph.prototype.openIn = function (world) {
             window.onbeforeunload = nop;
         }
         if (dict.noExitWarning) {
-            window.onbeforeunload = nop;
+            window.onbeforeunload = window.cachedOnbeforeunload;
         }
         if (dict.blocksZoom) {
             myself.savingPreferences = false;
@@ -897,6 +897,11 @@ IDE_Morph.prototype.applyConfigurations = function () {
     if (cnf.noCloud) {
         this.cloud.disable();
     }
+
+    // disable onbeforeunload close warning
+    if (cnf.noExitWarning) {
+        window.onbeforeunload = window.cachedOnbeforeunload;
+    }
 };
 
 IDE_Morph.prototype.applyPaneHidingConfigurations = function () {

diff --git a/src/morphic.js b/src/morphic.js
@@ -12469,7 +12469,11 @@ WorldMorph.prototype.initEventListeners = function () {
         false
     );
 
+    window.cachedOnbeforeunload = window.onbeforeunload;
     window.onbeforeunload = (evt) => {
+        if (window.cachedOnbeforeunload) {
+            window.cachedOnbeforeunload.call(null, evt);
+        }
         var e = evt || window.event,
             msg = "Are you sure you want to leave?";
         // For IE and Firefox