Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #109 Documentation for globalPalette option #126

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

cuixiping
Copy link

No description provided.

@iangilman
Copy link

@cuixiping I'm not a maintainer on this project, so this is just my opinion, and I don't know if @jnordberg is still active here, so it might not make any difference, but you're more likely to get your documentation change merged if it doesn't also have a whole new feature in the same branch.

The localPalette feature seems like a good one, and it looks like you've done a good job with it (based on my quick perusal of the code; I'm not terribly familiar with this codebase, though), but it really should be in its own branch and separate pull request.

Anyway, thank you for making this documentation fix… It's how I discovered the globalPalette feature which I'm needing!

@otizis
Copy link

otizis commented Jun 21, 2023

这个选项好像有个问题,全局调色盘的设置打开后似乎只会用第一帧的图像计算,导致后面帧出现的颜色只能从第一帧找相近的。比如第一帧是黑白的,那后面出现彩色的也无法找到彩色的,最后整个gif所有帧全部都变成黑白的了。

@cuixiping
Copy link
Author

这个选项好像有个问题,全局调色盘的设置打开后似乎只会用第一帧的图像计算,导致后面帧出现的颜色只能从第一帧找相近的。比如第一帧是黑白的,那后面出现彩色的也无法找到彩色的,最后整个gif所有帧全部都变成黑白的了。

globalPalette can be true, false, or an array of [r,g,b,r,g,b,...]. If globalPalette is true the global palette will be created from the first frame.

You can set globalPalette as an array of rgb values as you need.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants