Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Doc request: please explain which changes in 0.22 are breaking changes #801

Closed
jaredbeck opened this issue Jun 5, 2024 · 4 comments
Closed

Comments

@jaredbeck
Copy link
Contributor

Looking at the 0.22 release notes it's not clear to me which changes are breaking changes.

If there are breaking changes, could you please annotate them?

If not, may I suggest adding a line like "No breaking changes" or "No changes to public API"?

In SemVer, 0.x.x libraries are allowed to make breaking changes at any time, so documentation like this will be very helpful.

Thanks!

@jnunemaker
Copy link
Owner

jnunemaker commented Jun 5, 2024 via email

@jaredbeck
Copy link
Contributor Author

Dropping the support for old versions of Ruby was the breaking change.

IMHO, that's not a breaking change.

So, if that was the only notable change, I recommend adding a line like "No breaking changes" or "No changes to public API" to the release notes.

Thanks!

@jaredbeck
Copy link
Contributor Author

On a related note, removing the top-level requires in #760 may cause issues for some users who fail to require their own dependencies (speaking for a friend 😄 ) For example, if my friend's codebase requires CSV but they fail to specify that dependency in any way, then they will see NameError: uninitialized constant .. CSV after updating httparty to 0.22. This is not a breaking change in httparty, but you might choose, in an abundance of compassion, to mention it in the release notes. 😆

@jnunemaker
Copy link
Owner

@jaredbeck it is breaking if you use those versions. That's why I bumped. Most everything else should be pretty stable and has been for years.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants