Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lazy load some gems #760

Merged
merged 1 commit into from
Mar 20, 2024
Merged

Lazy load some gems #760

merged 1 commit into from
Mar 20, 2024

Conversation

orgads
Copy link
Contributor

@orgads orgads commented Aug 18, 2022

Only load them when they are used.

@orgads orgads force-pushed the lazy-require branch 2 times, most recently from 3927e57 to 6a6d976 Compare August 18, 2022 15:01
Only load them when they are used.
@orgads
Copy link
Contributor Author

orgads commented Oct 21, 2023

Rebased.

@jnunemaker jnunemaker merged commit b9bd421 into jnunemaker:master Mar 20, 2024
8 checks passed
@orgads orgads deleted the lazy-require branch March 20, 2024 13:21
@jaredbeck
Copy link
Contributor

Cross-posting this here, in case it helps someone:

On a related note, removing the top-level requires in #760 may cause issues for some users who fail to require their own dependencies (speaking for a friend 😄 ) For example, if my friend's codebase requires CSV but they fail to specify that dependency in any way, then they will see NameError: uninitialized constant .. CSV after updating httparty to 0.22. This is not a breaking change in httparty, but you might choose, in an abundance of compassion, to mention it in the release notes. 😆
#801 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants