Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade angular to >=12 <=16 #161

Merged
merged 5 commits into from
Nov 20, 2023
Merged

Upgrade angular to >=12 <=16 #161

merged 5 commits into from
Nov 20, 2023

Conversation

petrhavel2
Copy link
Collaborator

Breaking change is to upgrade angular to latest versions.

PeerDependencies:

  • upgraded peerDependencies of angular >=12 <=16, removed angular/http
  • peerDependency ngrx updated to latest version 16.3.0, without range as is for Angular

Structural changes

  • merged subproject /demo-app/client into main root project
    • it causes different unexpected behaviour in usage two sources of ./node_modules
    • /demo-app/client ... angular app was newer used except tests. Rest of code moved to folders in root
  • switched tslint to eslint
  • removed CI tests based on Dockerfile -> moved to GitHub Actions
  • removed /dist folder which is in .gitignore
  • code tests for generated code moved from /demo-app/client/tests to /tests

Functional changes

  1. updated generated code of ngrx/effects, change from @effect -> createEffect (pipe functionality verified)
  2. changes related to the new version of typescript (override extended function)
  3. added integer validator for forms
  4. fixed calling of commander
  5. support function createDir changed to create recursive structure

Test-case changes

  1. fixed test in param.spec.ts, collision of string[] and number[]
  2. upgraded tests to withContext
  3. fixed deleting properties for tests [registration.service.spec.ts], [put-order.service.spec.ts]

JaroslavSoldat
JaroslavSoldat previously approved these changes Oct 18, 2023
@jnwltr jnwltr merged commit f051ce7 into master Nov 20, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants