Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove defining inline for MVSC because no longer necessary #654

Merged
merged 1 commit into from
Jun 24, 2024
+0 −14
Merged

Remove defining inline for MVSC because no longer necessary #654

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 0 additions & 14 deletions setup.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,3 @@
import distutils.ccompiler
import glob
import os
import os.path
Expand Down Expand Up @@ -127,19 +126,6 @@
# HACK for testing
# gsl_version= ['0','0']

# MSVC: inline does not exist (not C99!); default = not necessarily actual, but will have to do for now...
# Note for the futureL could now get the actual compiler in the BuildExt class
# below
if distutils.ccompiler.get_default_compiler().lower() == "msvc":
extra_compile_args.append("-Dinline=__inline")
# only msvc compiler can be tested with initialize(), msvc is a default on windows
# check for 'msvc' not WIN32, user can use other compiler like 'mingw32', in such case compiler exists for them
try:
test_compiler = distutils.ccompiler.new_compiler()
test_compiler.initialize() # try to initialize a test compiler to see if compiler presented
except PlatformError: # this error will be raised if no compiler in the system
no_compiler = True

# To properly export GSL symbols on Windows, need to defined GSL_DLL and WIN32
if WIN32:
extra_compile_args.append("-DGSL_DLL")
Expand Down
Loading