Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Python 3.13 support #673

Merged
merged 2 commits into from
Jan 21, 2025
Merged

Add Python 3.13 support #673

merged 2 commits into from
Jan 21, 2025

Conversation

jobovy
Copy link
Owner

@jobovy jobovy commented Sep 13, 2024

This issue just tracks progress to fully changing the build/test infrastructure to Python 3.13. Python 3.13 wheels were already added in #674 and are part of the latest version (since the 1.10.1 release).

Ready to be merged as soon as numba releases 0.61.

This PR tracks progress towards fully supporting Python 3.13. Any necessary fixes will be done separately outside of this PR, so actual Python 3.13 support can be achieved for many platforms before achieving it for all. We believe, in fact, that galpy fully works, but it is hard to fully test until all dependencies support Python 3.13.

Current status:

  • Linux works almost 100%, but can't run tests dependent on JAX or numba, because they do not support Python 3.13 yet. This affects only the spherical DFs (for JAX) and the non-inertial-frame force tests. There appears to be an issue with use of pynbody in SnapshotRZPotential
    • Fix SnapshotRZPotential pynbody issue
    • Test JAX-dependent code
    • Test numba-dependent code
  • Mac does not work because of an issue with installing pynbody from source, but we believe it's status is the same as Linux.
    • run Mac tests --> require RC pynbody, but that's fine
  • Windows works, but numba can't be installed currently. But should work.
  • Wheels:
    • Build Python 3.13 wheels for all platforms

Copy link

codecov bot commented Sep 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.91%. Comparing base (bb31762) to head (13a036f).
Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##             main     #673     +/-   ##
=========================================
  Coverage   99.90%   99.91%             
=========================================
  Files         200      202      +2     
  Lines       29430    30823   +1393     
  Branches      564      655     +91     
=========================================
+ Hits        29403    30796   +1393     
  Misses         27       27             

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jobovy jobovy merged commit e0a9134 into main Jan 21, 2025
148 checks passed
@jobovy jobovy deleted the python-3.13 branch January 21, 2025 18:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant