Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi Joe,
I really like your work and I'd like to contribute to this library 👍
I see two axes of improvements for this project: code cleaning and new features.
For new features, it would be nice to be able to use the ScratchView from a xib or a storyboard (issue #6).
It would also be nice to be able to fetch the image easily (issue #4).
It would also be great to be able to dynamically change the width/height of the view.
For code cleaning, I suggest:
if self.delegate != nil { self.delegate.began(self) }
->delegate?.began(self)
for instanceMaybe we could also work on architecture. I think the class ScratchUIView is useless today, it's just a proxy for a delegate.
I think a good class ScratchView, with a nice set of features, can do all the work.
Here you have two commits to show you what I can do.
The changes are not backward compatible so I don't expect them to be merged as it.
But it could be a start for a version 2.
Tell me what you think about it, we can discuss somewhere else if you want.
Regards,
Roland.