Skip to content

Commit

Permalink
update test comment after clarification (#4158)
Browse files Browse the repository at this point in the history
* project.overlays: RIP available overlays

I don't think we still have the concept to selectively enable and
disable overlays, do we? N.b. the test has been disabled for ages
(not sure if it ever tested anything)

* Revert "project.overlays: RIP available overlays"

This reverts commit a3dbeb5.

* test comment after clarification

* Update console/src/test/scala/io/joern/console/workspacehandling/WorkspaceTests.scala

Co-authored-by: David Baker Effendi <[email protected]>

---------

Co-authored-by: David Baker Effendi <[email protected]>
  • Loading branch information
mpollmeier and DavidBakerEffendi authored Feb 14, 2024
1 parent e562976 commit 4777e41
Showing 1 changed file with 3 additions and 3 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -30,11 +30,11 @@ class WorkspaceTests extends AnyWordSpec with Matchers {

output should include(project.name)
output should include(inputPath)
// TODO reenable test - this has been broken for ages, the overlays handling via directories works in staged joern but not in our test setup
// what does work in both though is `cpg.metaData.overlays` - I'm asking around which way forward we want

// This relies on the file system and only works in a staged joern environment, not our workspace
// with a mock cpg. Will leave here just for illustratory purposes.
// output should include("foo,bar")
}

}

}
Expand Down

0 comments on commit 4777e41

Please sign in to comment.