[x2cpg] SourceFiles.determine too Coupled with X2CpgConfig

[DavidBakerEffendi]

Original report by @khemrajrathore

Describe the problem

Source Code

We have 4 overloaded variants of the determine function, many of which end up to one or two of the same ones, but the determine function at LNo 57 and LNo 77 doesn’t use the filterFiles function, and it doesn’t seem correct to me.

The function at LNo 57 is used at most places, which is not considering any exclusion rules provided in the field withIgnoredFilesRegex. This leaves the X2CpgConfig silently/unintentionally unutilized.

It is observed that there is a place for determine to be called without X2CpgConfig, but it is mistakenly confused by frontends that ingest source code for processing.

Desired Solution
Rename the function at LNo 57 to something like determineAll and replacing it with the function at LNo 64 where ever it is being called for processing files to be generated by the CPG. As well as inspect usages of LNo77 such that the result of the solution is that all frontends call determine that make use of the config.

Alternatives
Remove the function at LNo 57 and add another overloaded variant where the config is an optional argument so that developers are intentional about using it without X2CpgConfig

Points from @fabsx00:

• Perhaps the filtering should not exist in determine at all. This adds extra coupling and implicit functionality.
• Only a subset of the X2CpgConfig properties are used, and by simply passing the whole config, it is unclear what it's being used for.
• File ingestion and filtering may need a general refactor to be clearer to developers and improve maintainability.

[DavidBakerEffendi]

Resolved by #3813 and #3822