Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

X2CPG : Refactor implementation and usage of SourceFiles determine method #3813

Merged
merged 6 commits into from
Nov 10, 2023
Merged

X2CPG : Refactor implementation and usage of SourceFiles determine method #3813

merged 6 commits into from
Nov 10, 2023

Conversation

khemrajrathore
Copy link
Contributor

@khemrajrathore khemrajrathore commented Nov 9, 2023 •
edited
Loading

This PR addresses the following issue

As of today we have 5 different overloaded determine method for getting SourceFiles, as part of this PR

  • Removed the 2 determine methods which used X2CpgConfig
  • Refactored 1 determine method to use ignoredDefaultRegex, ignoredFilesRegex and ignoredFilesPath
  • Removed 1 determine method as it became redundant after refactor done by this PR

Effectively now we have 2 determine methods which can be used accordingly

Note - This refactoring is not applied to JsSrc2Cpg frontend, as there we have our own custom handling for ignored files

@fabsx00 fabsx00 self-requested a review November 9, 2023 17:05
fabsx00
fabsx00 approved these changes Nov 9, 2023
View reviewed changes
Copy link
Contributor

@fabsx00 fabsx00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Much better. Build is still red, but once it's green, let's get this merged.

@fabsx00 fabsx00 merged commit b917a05 into joernio:master Nov 10, 2023
5 checks passed
@khemrajrathore khemrajrathore mentioned this pull request Nov 13, 2023
Merged
DavidBakerEffendi pushed a commit that referenced this pull request Nov 13, 2023
@khemrajrathore
[kotlin2cpg] - Apply X2CpgConfig File Filtering in Kotlin (#3822)
ff5e780 
There was a bug, in Kotlin frontend where we are not applying file filtering to remove the excluded files. This PR takes care of that.

This PR is an extension of #3813
@DavidBakerEffendi DavidBakerEffendi mentioned this pull request Nov 14, 2023
Closed
@pandurangpatil pandurangpatil deleted the refactor-determineSourceFileMethod branch February 16, 2024 10:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fabsx00 fabsx00 fabsx00 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@khemrajrathore @fabsx00