Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ruby] RubyProgramSummary types derive ReadWriter #4477

Merged
merged 11 commits into from
Apr 25, 2024
Merged

[ruby] RubyProgramSummary types derive ReadWriter #4477

merged 11 commits into from
Apr 25, 2024

Conversation

AndreiDreyer
Copy link
Contributor

@AndreiDreyer AndreiDreyer commented Apr 22, 2024 •
edited
Loading

This PR:

  • adds derives ReadWriter to RubyField, RubyType in RubyProgramSummary
  • adds custom serialization/deserialization logic for RubyMethod

@AndreiDreyer AndreiDreyer added the ruby Relates to rubysrc2cpg label Apr 22, 2024
@AndreiDreyer AndreiDreyer self-assigned this Apr 22, 2024
@DavidBakerEffendi
Copy link
Collaborator

Here is a thread on what the error code means on this runner: https://stackoverflow.com/questions/77219743/what-is-exit-code-3221225781-on-windows

@AndreiDreyer AndreiDreyer mentioned this pull request Apr 22, 2024
Merged
@AndreiDreyer AndreiDreyer merged commit f4b534e into master Apr 25, 2024
5 checks passed
@max-leuthaeuser max-leuthaeuser deleted the andrei/ruby/extend-ruby-types-with-rw branch April 25, 2024 07:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DavidBakerEffendi DavidBakerEffendi DavidBakerEffendi approved these changes

@badly-drawn-wizards badly-drawn-wizards Awaiting requested review from badly-drawn-wizards

Assignees

@AndreiDreyer AndreiDreyer

Labels
ruby Relates to rubysrc2cpg
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@AndreiDreyer @DavidBakerEffendi @max-leuthaeuser