Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add sbt and php to MacOS runner #4490

Merged
merged 2 commits into from
Apr 25, 2024
Merged

Add sbt and php to MacOS runner #4490

merged 2 commits into from
Apr 25, 2024

Conversation

max-leuthaeuser
Copy link
Contributor

@max-leuthaeuser max-leuthaeuser commented Apr 25, 2024

Looks like they are no longer pre-installed.

Looks like its no longer pre-installed.
@max-leuthaeuser max-leuthaeuser changed the title Add sbt to MacOS runner Add sbt and php to MacOS runner Apr 25, 2024
@mpollmeier
Copy link
Contributor

yes that would make sense. macos 12 does list sbt, from 13 onwards it's gone:
https://github.com/actions/runner-images/blob/main/images/macos/macos-12-Readme.md
https://github.com/actions/runner-images/blob/main/images/macos/macos-13-Readme.md
https://github.com/actions/runner-images/blob/main/images/macos/macos-14-Readme.md

php is listed as preinstalled even on macos 14 though... (PHP 8.3.6)

@max-leuthaeuser
Copy link
Contributor Author

Which is very strange as we are using macos-latest for quite a while now and it worked until yesterday...
php2cpg failed in a previous run complaining that no valid php could be found. Thats why I added that also.

@max-leuthaeuser max-leuthaeuser merged commit 872d86c into master Apr 25, 2024
5 checks passed
@max-leuthaeuser max-leuthaeuser deleted the max/macOSsbt branch April 25, 2024 06:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants