Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ruby] loop Do Block & Break Expressions #4524

Merged
merged 4 commits into from
May 2, 2024

Conversation

DavidBakerEffendi
Copy link
Collaborator

@DavidBakerEffendi DavidBakerEffendi commented May 2, 2024

  • Handles break statements on an expression level
  • Lower loop do statements as DoWhile expressions

Resolves #4508

Handles `break` statements on an expression level

Resolves #4508
@DavidBakerEffendi DavidBakerEffendi added the ruby Relates to rubysrc2cpg label May 2, 2024
@DavidBakerEffendi DavidBakerEffendi self-assigned this May 2, 2024
@DavidBakerEffendi
Copy link
Collaborator Author

Looking into failing associated data-flow test

@DavidBakerEffendi DavidBakerEffendi changed the title [ruby] Break Expressions [ruby] loop Do Block & Break Expressions May 2, 2024
@DavidBakerEffendi DavidBakerEffendi merged commit deb8842 into master May 2, 2024
5 checks passed
@DavidBakerEffendi DavidBakerEffendi deleted the dave/ruby/loop-break-statement branch May 2, 2024 14:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ruby Relates to rubysrc2cpg
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[ruby] BreakStatement cannot represent expression in loop
2 participants