[c2cpg] Improvements for range-based for-statement and local code fields #5215
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
max-leuthaeuser
commented
Jan 9, 2025
max-leuthaeuser
commented
- range-based for-statement blocks had multiple outgoing CFG edges because the children were not wrapped into blocks.
- code fields for locals from NamedTypeSpecifiers now preserve static and const modifier
- range-based for-statement blocks had multiple outgoing CFG edges because the children were not wrapped into blocks. - code fields for locals from NamedTypeSpecifiers now preserve static and const modifier
maltek
approved these changes
Jan 9, 2025
| @@ -142,14 +142,16 @@ trait AstCreatorHelper(implicit withSchemaValidation: ValidationMode) { this: As | |||
| "class" | |||
| ) | |||
|
|
|||
| private val KeepTypeKeywords: List[String] = List("unsigned", "volatile") | |||
| private val KeepTypeKeywords: List[String] = List("unsigned", "volatile", "const", "static") | |||
There was a problem hiding this comment.
I'd rename this, since static is decidedly not part of the type. (I think it's called a storage modifier.)
There was a problem hiding this comment.
Well, it's a list of keywords to keep at the string representation of a type. I keep it that way for now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.