[sarif] Add Reporting Descriptors & More "Optionality" #5269
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
DavidBakerEffendi
commented
Jan 29, 2025
DavidBakerEffendi
commented
- Added reporting descriptors which allow one to add more meta data to rules, and link findings to a given existing entry.
- Moved the sarif instantiation to the RunBeforeCode object which separates actions from tools deriving from Joern
- Using more "optional" properties where possible on properties which are not required by the sarif schema
* Added reporting descriptors which allow one to add more meta data to rules, and link findings to a given existing entry. * Moved the sarif instantiation to the RunBeforeCode object which separates actions from tools deriving from Joern * Using more "optional" properties where possible on properties which are not required by the sarif schema
mpollmeier
approved these changes
Jan 29, 2025
| @@ -21,11 +21,11 @@ object Schema { | |||
| final case class ArtifactLocation(uri: Option[URI] = None, uriBaseId: Option[String] = Option("PROJECT_ROOT")) | |||
| extends SarifSchema.ArtifactLocation | |||
|
|
|||
| final case class CodeFlow(message: Message, threadFlows: List[ThreadFlow]) extends SarifSchema.CodeFlow | |||
| final case class CodeFlow(message: Option[Message] = None, threadFlows: List[ThreadFlow]) extends SarifSchema.CodeFlow | |||
There was a problem hiding this comment.
parameters with default values should come last
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.