Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: update README.md with host bucket example #92

Merged
merged 1 commit into from
Jul 1, 2024

Conversation

armsnyder
Copy link
Contributor

@armsnyder armsnyder commented Jun 3, 2024

The SDK V2 example in the readme did not work for me. The readme suggestion to use WithS3ForcePathStyle only works with SDK V1. I had to make these changes to the V2 example.

  1. Configure gofakes3 to use host bucket
  2. Configure the test server with a custom dialer that strips the bucket subdomain before dialing

Related to #32

Copy link

sonarcloud bot commented Jun 3, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 65.99%. Comparing base (99de01e) to head (9212989).

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff           @@
##           master      #92   +/-   ##
=======================================
  Coverage   65.99%   65.99%           
=======================================
  Files          28       28           
  Lines        2697     2697           
=======================================
  Hits         1780     1780           
  Misses        651      651           
  Partials      266      266           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@johannesboyne johannesboyne merged commit edd0227 into johannesboyne:master Jul 1, 2024
4 checks passed
@johannesboyne
Copy link
Owner

Thanks @armsnyder for the contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants