Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improved algorithm for computing mc_offset including bugfix #95

Merged
merged 8 commits into from
Sep 1, 2023
Merged

Improved algorithm for computing mc_offset including bugfix #95

merged 8 commits into from
Sep 1, 2023

Commits on Aug 30, 2023

  1. updates expected test results with v2.1.1

    @johentsch
    johentsch committed Aug 30, 2023
    Configuration menu
    Copy the full SHA
    b051ad4 View commit details
    Browse the repository at this point in the history

  2. replaces Mozart testfile K281-3.mscx with K284-3_section_breaks.mscx 

    it corresponds to mozart_piano_sonatas/MS3/ambiguous_measure_numbers/ambiguous_measure_numbers_for_K284-3.mscx but after correcting for the inconsistency that MuseScore introduces in ordering Clef-Harmony-Dynamic tags
    @johentsch
    johentsch committed Aug 30, 2023
    Configuration menu
    Copy the full SHA
    e3d4f33 View commit details
    Browse the repository at this point in the history

  3. updates the outdated annotations in the 284-3_section_breaks test file

    @johentsch
    johentsch committed Aug 30, 2023
    Configuration menu
    Copy the full SHA
    17eee2a View commit details
    Browse the repository at this point in the history

  4. introduces comments, accounts for "section" breaks co-occurring with … 

    …other breaks (e.g. "line", "page", which come separated with " & ")
    @johentsch
    johentsch committed Aug 30, 2023
    Configuration menu
    Copy the full SHA
    b1d0d5b View commit details
    Browse the repository at this point in the history

  5. first draft for imitating/copying the function's behaviour

    @johentsch
    johentsch committed Aug 30, 2023
    Configuration menu
    Copy the full SHA
    0ed60e6 View commit details
    Browse the repository at this point in the history

Commits on Aug 31, 2023

  1. docstring

    @johentsch
    johentsch committed Aug 31, 2023
    Configuration menu
    Copy the full SHA
    2f9d7b4 View commit details
    Browse the repository at this point in the history

  2. first working version of the improved make_offset_col() function

    @johentsch
    johentsch committed Aug 31, 2023
    Configuration menu
    Copy the full SHA
    314893c View commit details
    Browse the repository at this point in the history

  3. turns print into the appropriate log messages

    @johentsch
    johentsch committed Aug 31, 2023
    Configuration menu
    Copy the full SHA
    5b820d5 View commit details
    Browse the repository at this point in the history