Skip to content

Commit

Permalink
chore: manual merge
Browse files Browse the repository at this point in the history
  • Loading branch information
johnstonskj committed Jul 19, 2024
1 parent 0cd4782 commit eadd524
Show file tree
Hide file tree
Showing 3 changed files with 7 additions and 2 deletions.
2 changes: 1 addition & 1 deletion Cargo.toml
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
[package]
name = "email_address"
version = "0.2.5"
version = "0.2.6"
authors = ["Simon Johnston <[email protected]>"]
description = "A Rust crate providing an implementation of an RFC-compliant `EmailAddress` newtype. "
documentation = "https://docs.rs/email_address/"
Expand Down
4 changes: 4 additions & 0 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -59,6 +59,10 @@ assert_eq!(

## Changes

### Version 0.2.6

- Fix: merge issues.

### Version 0.2.5

* Feature: Pull Request #15 -- Potential enhancement to add any free-text as
Expand Down
3 changes: 2 additions & 1 deletion src/lib.rs
Original file line number Diff line number Diff line change
Expand Up @@ -354,7 +354,7 @@ impl Default for Options {
/// create an instance. The various components of the email _are not_ parsed out to be accessible
/// independently.
///
#[derive(Debug, Clone, PartialEq, Eq, Hash)]
#[derive(Debug, Clone)]

This comment has been minimized.

Copy link
@RemiBardon

RemiBardon Jul 25, 2024

Why were these removed?

This comment has been minimized.

Copy link
@johnstonskj

johnstonskj Jul 31, 2024

Author Owner

A correct implementation is provided below for PartialEq and Hash.

This comment has been minimized.

Copy link
@RemiBardon

RemiBardon Aug 2, 2024

I hadn't seen. Unfortunately Eq was missing (guess you fixed it now)

pub struct EmailAddress(String);

// ------------------------------------------------------------------------------------------------
Expand Down Expand Up @@ -1589,6 +1589,7 @@ mod tests {
Deserializer::builder(assert_ok!(email.serialize(&serializer))).build();

assert_ok_eq!(EmailAddress::deserialize(&mut deserializer), email);
}

#[test]
// Regression test: GitHub issue #11
Expand Down

0 comments on commit eadd524

Please sign in to comment.