Change pydecimal type hint for min_value, max_value to numbers.Number
#2059
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
parsariyahi
changed the title
pydecimal type hint for min_value, max_value to numbers.Number #2041pydecimal type hint for min_value, max_value to numbers.Number
|
@parsariyahi @fcurella You guys forgot to regenerate stubs files... The file Also it seems that this issue can be closed (at least for me all mypy errors disappeared): #2041 |
|
@sshishov I see the types updated. What version of |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this change
in
faker\providers\python\__init__.pymethodpydecimalI changed the type hints formin_value,max_valuetonumbers.NumberWhat was wrong
#2041 issue in
mypyfortype hintsHow this fixes it
This PR will use
numbers.Numberinstead offloatfor type hint