Agrega servicio REST y persistencia con Room #11
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Cambiado el tiempo de intervalo de consulta a la API de 1 minuto a 1 hora.
alefq
reviewed
Jun 3, 2018
| } catch (RuntimeException e) { | ||
| Utils.showToast(getBaseContext(), String.format("Fallo de CountryHelper")); | ||
| Toast.makeText(getBaseContext(), getBaseContext().getString(R.string.no_network_connection), Toast.LENGTH_SHORT).show(); | ||
| Log.e(LOG_TAG, getBaseContext().getString(R.string.no_network_connection), e); |
There was a problem hiding this comment.
Si falla por una excepción, la excepción debe incluirse en todos los Log.e como tercer parámetro, para ver el stacktrace en el log.
Cambiar esto en todos los lugares dónde se usa Log.e dentro de un catch
Removida para evitar crashes al logearse en la aplicacion.
alefq
approved these changes
Jun 12, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Soluciona #2