Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nuevo sistema Mboehao #25

Merged
merged 32 commits into from
Jun 4, 2020
Merged

Nuevo sistema Mboehao #25

merged 32 commits into from
Jun 4, 2020

Conversation

AleEI92
Copy link
Contributor

@AleEI92 AleEI92 commented Jun 3, 2020

Nuevas funcionalidades, implementado Material Design.
Corregido varios errores y warnings.

AleEI92 added 30 commits May 31, 2020 18:43
import io.github.jokoframework.otp.OtpActivity;
import io.github.jokoframework.service.TestServiceNotification;

public class Home2Activity extends AppCompatActivity implements NavigationView.OnNavigationItemSelectedListener {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Debería quedar un sólo HomeActivity, el más nuevo que veo que es esta Clase. Aplicar ese cambio a todo el proyecto.
No tiene sentido mantener el que ya no funciona con las nuevas APIs, en todo caso; dejar con el mismo nombre y eliminar esta clase; para que no sea necesario cambiar en todas las clases que hacen referencia al nombre HomeActivity.

Copy link
Contributor Author

@AleEI92 AleEI92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Closes #26

@alefq alefq merged commit 0f7085a into jokoframework:develop Jun 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants