Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow failure on cache:warmup command #338

Merged
merged 1 commit into from
Jan 15, 2025
Merged

Allow failure on cache:warmup command #338

merged 1 commit into from
Jan 15, 2025

Conversation

JorickPepin
Copy link
Member

In the castor start task, composer install is called after cache:warmup, so when the stack is started after a dependency change, the cache warm-up can fail.

pyrech
pyrech approved these changes Jan 15, 2025
View reviewed changes
Copy link
Member

@pyrech pyrech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@pyrech pyrech merged commit d1daa2d into main Jan 15, 2025
4 checks passed
@pyrech pyrech deleted the fix/cache-warmup branch January 15, 2025 16:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pyrech pyrech pyrech approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JorickPepin @pyrech