Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests: add axis data checks for all plots available in GUI #697

Closed
gtdang opened this issue Dec 11, 2023 · 3 comments
Closed

tests: add axis data checks for all plots available in GUI #697

gtdang opened this issue Dec 11, 2023 · 3 comments
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@gtdang
Copy link
Collaborator

gtdang commented Dec 11, 2023

Add checks to test_gui.py to make sure all GUI plots actually plot data on the axis. See #695 for the added checks on the default plots. Currently there are no checks (aside from the default plots) to make sure plots are not empty. Empty plots can occur when an error occurs between clicking the plot/run button and the GUI calling the plot function from the viz module.

The default figures are the figures that are automatically generated after running a simulation. The figures that need to be checked are the figures that the user can manually create using the Visualization tab. See image below.
Screenshot 2024-03-12 at 10 33 34 AM

Of this list "current dipole" and "histogram" don't need checks as they are part of the default set of plots. The others will need to have unique test functions developed except for the spectrogram, which already has a unique test test_gui_adaptive_spectrogram. However the spectrogram does need to have a check for if data is plotted.

@jasmainak
Copy link
Collaborator

Absolutely ... PR is welcome!

@gtdang gtdang added enhancement New feature or request good first issue Good for newcomers labels Dec 21, 2023
@samadpls
Copy link
Contributor

@jasmainak, can I take this issue? 😋

@samadpls
Copy link
Contributor

samadpls commented Apr 2, 2024

Closed via #726 - task completed.

@rythorpe rythorpe closed this as completed Apr 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

4 participants