-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[MRG] Added data check on axes in test_gui.py
#726
[MRG] Added data check on axes in test_gui.py
#726
Conversation
Signed-off-by: samadpls <[email protected]>
@gtdang can you review? |
Signed-off-by: samadpls <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #726 +/- ##
==========================================
+ Coverage 89.06% 89.44% +0.37%
==========================================
Files 28 28
Lines 5068 5068
==========================================
+ Hits 4514 4533 +19
+ Misses 554 535 -19 ☔ View full report in Codecov by Sentry. |
Also, @samadpls, if you use the word "fixes" or "closes" followed by the issue tag, GH will automatically detect it and close the associated issue when your PR gets merged. Just a fun trick! 😄 |
Signed-off-by: samadpls <[email protected]>
@gtdang, thank you for your suggestions. 🙌🏻 I have added the test cases for the mentioned plots above. Please let me know if there's anything else I need to address |
Signed-off-by: samadpls <[email protected]>
Signed-off-by: samadpls <[email protected]>
Signed-off-by: samadpls <[email protected]>
@jasmainak @dylansdaniels @ntolley Do we update the whats_new.rst for a change like this? Or only user-facing changes? |
No updates to |
Signed-off-by: samadpls <[email protected]>
|
||
|
||
@pytest.mark.parametrize("viz_type", ["layer2 dipole", "layer5 dipole", | ||
"spikes", "PSD", "network"]) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lol ... I'm glad I made you do this ;-)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great!
test_gui.py
test_gui.py
We want to keep the commit history clean ... the diff should have been one or two commits. Rebase and merge is good when it's a bigger PR and we want to track the history of the changes. |
* add data check on axes in `test_gui.py` Signed-off-by: samadpls <[email protected]> * refactored Signed-off-by: samadpls <[email protected]> * Added tests for GUI visualization features Signed-off-by: samadpls <[email protected]> * fixed linting error Signed-off-by: samadpls <[email protected]> * added doc string Signed-off-by: samadpls <[email protected]> * Remove unnecessary code assertions Signed-off-by: samadpls <[email protected]> * Refactor visualization test Signed-off-by: samadpls <[email protected]> * refactor --------- Signed-off-by: samadpls <[email protected]>
Fixes issue #697
test_gui.py