Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: refactoring hard coded parts in renaming cells in HNN #702

Open
wants to merge 7 commits into
base: master
Choose a base branch
from

Commits on Aug 11, 2024

  1. WIP: refactoring hard coded parts in renaming cells in HNN

    removing hard coding in _create_cell_coords function and linking this with __init__ in class Network
    
    fixing the _create_cell_coords
    
    refactoring _create_cell_coords
    
    refactoring _create_cell_coords contd
    
    removing cell_name from 466 argument
    
    correcting styling error and fixing self.post_dict in class network
    
    making different corrections in network
    
    fixed line 463
    
    working with line 465 network.py
    
    still working with line 407
    
    adding a space
    
    added self before cell_types
    
    commented line 404 and added self to cell_types to make it an attribute to instance network
    
    de-indenting line 115 for pos_dict to get input from the whole code
    
    de-indenting lines 103 thru 115 in network
    
    corrected names of cells to match cell.name
    
    added a comment on the plan lines 81 thru 86 in network_models
    
    changing cell name to L2_basket
    
    added a rename_cell function and _rename_basket subfunction WIP
    
    making some re-organizing of comments to rename_cell function
    
    rename is working with gid_ranges ordered, still working on visualization
    
    fixing a typo
    
    modified rename function to order cell_types items
    
    visualization raster working and colors matching
    
    fixing extra white spaces etc...
    
    .
    
    Updating plot cell function WIP
    
    maintain original order in net.gid_ranges only
    
    modify net.gid_ranges in loop to simplify rename_cell
    
    cleaning up code
    
    modifying the discription
    
    removing extra lines
    
    fixed color_map in plot_raster
    
    marker set to o for all cells
    
    adding tests
    
    aethetic modification
    
    correct elif or error
    
    correcting a typo
    
    correcting pytests
    
    updating pytest
    
    fixing network tests
    
    cell-repsonse test
    
    _add_cell-type
    wagdy88 committed Aug 11, 2024
    Configuration menu
    Copy the full SHA
    569a90a View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    f971497 View commit details
    Browse the repository at this point in the history
  3. correcting test_cell_response

    wagdy88 committed Aug 11, 2024
    Configuration menu
    Copy the full SHA
    ce4e891 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    01876fb View commit details
    Browse the repository at this point in the history
  5. changing net.__repr__

    wagdy88 committed Aug 11, 2024
    Configuration menu
    Copy the full SHA
    6b1d018 View commit details
    Browse the repository at this point in the history

Commits on Sep 25, 2024

  1. space

    wagdy88 committed Sep 25, 2024
    Configuration menu
    Copy the full SHA
    86474d7 View commit details
    Browse the repository at this point in the history
  2. remove space

    wagdy88 committed Sep 25, 2024
    Configuration menu
    Copy the full SHA
    2ce5c16 View commit details
    Browse the repository at this point in the history