-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP: refactoring hard coded parts in renaming cells in HNN #702
Open
wagdy88
wants to merge
7
commits into
jonescompneurolab:master
Choose a base branch
from
wagdy88:refactor_cell_name
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Commits on Aug 11, 2024
-
WIP: refactoring hard coded parts in renaming cells in HNN
removing hard coding in _create_cell_coords function and linking this with __init__ in class Network fixing the _create_cell_coords refactoring _create_cell_coords refactoring _create_cell_coords contd removing cell_name from 466 argument correcting styling error and fixing self.post_dict in class network making different corrections in network fixed line 463 working with line 465 network.py still working with line 407 adding a space added self before cell_types commented line 404 and added self to cell_types to make it an attribute to instance network de-indenting line 115 for pos_dict to get input from the whole code de-indenting lines 103 thru 115 in network corrected names of cells to match cell.name added a comment on the plan lines 81 thru 86 in network_models changing cell name to L2_basket added a rename_cell function and _rename_basket subfunction WIP making some re-organizing of comments to rename_cell function rename is working with gid_ranges ordered, still working on visualization fixing a typo modified rename function to order cell_types items visualization raster working and colors matching fixing extra white spaces etc... . Updating plot cell function WIP maintain original order in net.gid_ranges only modify net.gid_ranges in loop to simplify rename_cell cleaning up code modifying the discription removing extra lines fixed color_map in plot_raster marker set to o for all cells adding tests aethetic modification correct elif or error correcting a typo correcting pytests updating pytest fixing network tests cell-repsonse test _add_cell-type
Configuration menu - View commit details
-
Copy full SHA for 569a90a - Browse repository at this point
Copy the full SHA 569a90aView commit details -
Configuration menu - View commit details
-
Copy full SHA for f971497 - Browse repository at this point
Copy the full SHA f971497View commit details -
Configuration menu - View commit details
-
Copy full SHA for ce4e891 - Browse repository at this point
Copy the full SHA ce4e891View commit details -
Configuration menu - View commit details
-
Copy full SHA for 01876fb - Browse repository at this point
Copy the full SHA 01876fbView commit details -
Configuration menu - View commit details
-
Copy full SHA for 6b1d018 - Browse repository at this point
Copy the full SHA 6b1d018View commit details
Commits on Sep 25, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 86474d7 - Browse repository at this point
Copy the full SHA 86474d7View commit details -
Configuration menu - View commit details
-
Copy full SHA for 2ce5c16 - Browse repository at this point
Copy the full SHA 2ce5c16View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.