-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[MRG] Dev extras #703
[MRG] Dev extras #703
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #703 +/- ##
=======================================
Coverage 91.35% 91.35%
=======================================
Files 25 25
Lines 4606 4606
=======================================
Hits 4208 4208
Misses 398 398 ☔ View full report in Codecov by Sentry. |
@@ -115,9 +115,13 @@ repository and use pip with the editable (``-e``) flag:: | |||
|
|||
$ git clone https://github.com/jonescompneurolab/hnn-core | |||
$ cd hnn-core | |||
$ pip install -e '.[gui]' | |||
$ pip install -e '.[dev]' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is beautiful!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Don't you have to update circleci.yml too?
@gtdang you should make a branch to your own fork, not to the main repo. For now it's okay, just remember to delete |
This reverts commit be4f379.
…s for examples using mne.
.circleci/config.yml
Outdated
@@ -30,15 +30,13 @@ jobs: | |||
conda create -n testenv --yes pip python=3.8 | |||
source activate testenv | |||
conda install --yes scipy numpy matplotlib | |||
pip install mne pooch tqdm psutil mpi4py joblib nibabel | |||
pip install pooch tqdm mpi4py |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
do you still need to install pooch and tqdm separately?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We don't! Thanks for catching that!
@gtdang I enabled auto-merge. Don't forget to delete the Thanks a lot for your contributions 🙏 🥳 |
This is a small PR to improve the classification & organization of extra dependencies. The key benefits to this change are:
pip install -e '.[dev]'
, to get all the dependencies for joblib, GUI, test, docs generation.Note:
parallel
group. So developers will still need to manually install mpi4py and openmpi as recommended in the contributor guide.To do: