Record calcium concentration new #804
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@katduecker you probably need to rebase this branch in order to run successfully the checklist. |
|
Thanks! |
|
Looks like this is the offending line: Just to double check, does the |
|
Yep, somehow cell_response.ca was in the wrong line. Thanks for pointing me to it :) |
ntolley
reviewed
Jul 3, 2024
| @@ -200,7 +200,7 @@ API | |||
| :meth:`~hnn_core.extracellular.ExtracellularArray.plot_lfp`, by | |||
| `Steven Brandt`_ and `Ryan Thorpe`_ in :gh:`517`. | |||
|
|
|||
| - Recorded voltages/currents from the soma, as well all sections, are enabled by | |||
| - Recorded voltages/currents from the soma, as well as all sections, are enabled by | |||
ntolley
reviewed
Jul 3, 2024
ntolley
reviewed
Jul 3, 2024
|
Great work @katduecker!! We should definitely put together an example showing off how the |
|
Also can you update the title to have the [MRG] tag and get rid of "new"? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sorry to have opened a new PR, I had some merging conflicts. This one supersedes #792
We decided that the absolute values of the calcium concentration may not be interpretable, which is not a problem, but probably something we want to state in publications that use the feature!