[WIP] Feat GUI add connection probability #843
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ntolley
reviewed
Jul 31, 2024
| value=conn_data[receptor_name]['weight'], disabled=False, | ||
| continuous_update=False, min=0, max=1e6, step=0.01, | ||
| description="weight", style=style) | ||
| probability_text_input = BoundedFloatText( | ||
| value=conn_data[receptor_name]['probability'], disabled=False, |
There was a problem hiding this comment.
A simple test to run would be to reduce the probability of one of the connections, and assert that there are fewer gid_pairs
gtdang
force-pushed
the
feat-gui-add-connection-probability
branch
from
e2d7efa to
7ccc2b8
Compare
|
This PR is on hold. The problem is that if probability is changed, gid_pairs also needs to be recalculated. Work from this PR can be used once a means to update connection probabilities and associated parameters is implemented. This can either be on an API level, or changing the logic of the GUI to rebuild connections on Network init. A patch fix to remove the GUI probability assignment logic was made in #844. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add connection probability to connection accordion boxes.
[] Add probability widgets to connection boxes
[] Test for connection box elements
[] Test for change in network construction