[MRG] feat: post-processing function to adjust figures #893
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e been constructed This was created for a special case where L2 and L5 dipole plots should have the same axis limits. There wasn't a simple way to set axis limits upon creation so the post-process seemed like the most simple solution while keeping the current api intact.
gtdang
changed the title
The self.figs attribute is a dictionary with int keys. We obtain the latest figure by using the stored figure index from the data attribute.
gtdang
changed the title
… needs processing
gtdang
commented
Sep 20, 2024
| # template post-processing | ||
| fig_key = self.data['fig_idx']['idx'] - 1 | ||
| _postprocess_template(template_name, | ||
| fig=self.figs[fig_key], |
There was a problem hiding this comment.
@ntolley
This was the PR I was showing you that was glitching and preventing further figure creation after deleting figures a few times. The issue was at this line where I was previously indexing self.figs with a the length of itself, because I assumed it was a list and I wanted the latest created figure. Turns out thatself.figs is a dict with ints as keys and the length of the dict doesn't correspond to the keys after you delete from and add to it. Using the int stored in self.data['fig_idx']['idx'] as the key fixed the issue.
|
@gtdang are we sure all the plots are being iterated over to find ymin/ymax? The 3rd plot seems to have different ylims here: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a post-processing function to adjust figures after they have been constructed
This was created for a special case where L2 and L5 dipole plots should have the same axis limits. There wasn't a simple way to set axis limits upon plot creation so the post-process implementation seemed like the most simple solution while keeping the current APIs intact.
Admittedly this solution is a bit hacky as it renders the first set a plots and quickly re-renders the adjustment (looks like a flicker). Perhaps adding keywords to not render certain plot calls would be a solution.