Refactor tag assertion to FatalError check & Fix unexpected increase of tag (fork) #284
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files
|
|
One test fails but it is not related to this PR. |
jonhoo
approved these changes
Mar 31, 2024
|
Let's get this merged
Awesome, thank you! Do you think it could be possible to release a new
alpha version? I need this fix to release a new version of mine.
|
jonhoo
added a commit
that referenced
this pull request
Mar 31, 2024
jonhoo
added a commit
that referenced
this pull request
Mar 31, 2024
|
Published as 3.0.0-alpha.13 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is just a fork of #231 so it can be finished and merged.
This change is