Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Two.Arc listeners for width and height changes #729

Merged
merged 2 commits into from
Jun 24, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
74 changes: 38 additions & 36 deletions extras/js/arc.js
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
(function() {

(function () {
const TWO_PI = Math.PI * 2;
const cos = Math.cos, sin = Math.sin;
const cos = Math.cos,
sin = Math.sin;

/**
* @name Two.Arc
Expand All @@ -16,7 +16,6 @@
* @param {Number} [resolution=4] - The number of vertices used to construct the circle.
*/
class Arc extends Two.Path {

_flagWidth = false;
_flagHeight = false;
_flagStartAngle = false;
Expand All @@ -28,7 +27,6 @@
_endAngle = TWO_PI;

constructor(x, y, width, height, startAngle, endAngle, resolution) {

if (typeof resolution !== 'number') {
resolution = Two.Resolution;
}
Expand Down Expand Up @@ -87,7 +85,6 @@
if (typeof y === 'number') {
this.position.y = y;
}

}

/**
Expand All @@ -105,31 +102,31 @@
* @nota-bene Try not to call this method more than once a frame.
*/
_update() {

if (this._flagVertices || this._flagRadius || this._flagStartAngle
|| this._flagEndAngle) {

if (
this._flagVertices ||
this._flagRadius ||
this._flagStartAngle ||
this._flagWidth ||
this._flagHeight ||
this._flagEndAngle
) {
const { width, height, startAngle, endAngle, vertices } = this;
const rx = width / 2;
const ry = height / 2;

for (let i = 0; i < vertices.length; i++) {

const v = vertices[i];
const pct = i / (vertices.length - 1);
const theta = pct * (endAngle - startAngle) + startAngle;

v.x = rx * cos(theta);
v.y = ry * sin(theta);

}

}

super._update.call(this);

return this;

}

/**
Expand All @@ -139,14 +136,15 @@
* @description Called internally to reset all flags. Ensures that only properties that change are updated before being sent to the renderer.
*/
flagReset() {

super.flagReset.call(this);

this._flagWidth = this._flagHeight = this._flagStartAngle
= this._flagEndAngle = false;
this._flagWidth =
this._flagHeight =
this._flagStartAngle =
this._flagEndAngle =
false;

return this;

}

/**
Expand All @@ -157,11 +155,18 @@
* @description Create a new instance of {@link Two.ArcSegment} with the same properties of the current path.
*/
clone() {

const { width, height, startAngle, endAngle } = this;
const resolution = this.vertices.length;

const clone = new Arc(0, 0, width, height, startAngle, endAngle, resolution);
const clone = new Arc(
0,
0,
width,
height,
startAngle,
endAngle,
resolution
);

clone.position.copy(this.position);
clone.rotation = this.rotation;
Expand All @@ -183,62 +188,59 @@
}

return clone;

}

}

const protos = {
width: {
enumerable: true,
get: function() {
get: function () {
return this._width;
},
set: function(v) {
set: function (v) {
if (v !== this._width) {
this._width = v;
this._flagWidth = true;
}
}
},
},
height: {
enumerable: true,
get: function() {
get: function () {
return this._height;
},
set: function(v) {
set: function (v) {
if (v !== this._height) {
this._height = v;
this._flagHeight = true;
}
}
},
},
startAngle: {
enumerable: true,
get: function() {
get: function () {
return this._startAngle;
},
set: function(v) {
set: function (v) {
if (v !== this._startAngle) {
this._startAngle = v;
this._flagStartAngle = true;
}
}
},
},
endAngle: {
enumerable: true,
get: function() {
get: function () {
return this._endAngle;
},
set: function(v) {
set: function (v) {
if (v !== this._endAngle) {
this._endAngle = v;
this._flagEndAngle = true;
}
}
}
},
},
};

Two.Arc = Arc;

})();
30 changes: 6 additions & 24 deletions extras/js/zui.js
Original file line number Diff line number Diff line change
@@ -1,13 +1,10 @@
(function() {

(function () {
class Surface {

constructor(object) {
this.object = object;
}

limits(min, max) {

const min_exists = typeof min !== 'undefined';
const max_exists = typeof max !== 'undefined';

Expand All @@ -19,15 +16,13 @@
this.max = max_exists ? max : this.max;

return this;

}

apply(px, py, s) {
this.object.translation.set(px, py);
this.object.scale = s;
return this;
}

}

/**
Expand All @@ -37,20 +32,18 @@
* @param {HTMLElement} [domElement=document.body] - The HTML Element to attach event listeners to.
*/
class ZUI {

constructor(group, domElement) {

this.limits = {
scale: ZUI.Limit.clone(),
x: ZUI.Limit.clone(),
y: ZUI.Limit.clone()
y: ZUI.Limit.clone(),
};

this.viewport = domElement || document.body;
this.viewportOffset = {
top: 0,
left: 0,
matrix: new Two.Matrix()
matrix: new Two.Matrix(),
};

this.surfaceMatrix = new Two.Matrix();
Expand All @@ -60,7 +53,6 @@
this.updateSurface();

this.add(new Surface(group));

}

static Surface = Surface;
Expand All @@ -72,14 +64,14 @@
static Limit = {
min: -Infinity,
max: Infinity,
clone: function() {
clone: function () {
const result = {};
for (let k in this) {
result[k] = this[k];
}
return result;
}
}
},
};

static TranslateMatrix(m, x, y) {
m.elements[2] += x;
Expand All @@ -105,7 +97,6 @@
}

addLimits(min, max) {

if (typeof min !== 'undefined') {
if (this.limits.scale.min) {
this.limits.scale.min = Math.max(min, this.limits.scale.min);
Expand All @@ -125,7 +116,6 @@
}

return this;

}

clientToSurface(a, b, c) {
Expand Down Expand Up @@ -173,7 +163,6 @@
}

zoomSet(zoom, clientX, clientY) {

const newScale = this.fitToLimits(zoom);
this.zoom = ZUI.ScaleToPosition(newScale);

Expand All @@ -193,7 +182,6 @@
this.translateSurface(dx, dy);

return this;

}

translateSurface(x, y) {
Expand All @@ -203,7 +191,6 @@
}

updateOffset() {

const rect = this.viewport.getBoundingClientRect();

this.viewportOffset.left = rect.left - document.body.scrollLeft;
Expand All @@ -214,18 +201,15 @@
.translate(this.viewportOffset.left, this.viewportOffset.top);

return this;

}

updateSurface() {

const e = this.surfaceMatrix.elements;
for (let i = 0; i < this.surfaces.length; i++) {
this.surfaces[i].apply(e[2], e[5], e[0]);
}

return this;

}

reset() {
Expand All @@ -238,9 +222,7 @@
fitToLimits(s) {
return ZUI.Clamp(s, this.limits.scale.min, this.limits.scale.max);
}

}

Two.ZUI = ZUI;

})();
Loading
Loading