Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvement to WebGL Rendering: Handle Negative Scales #738

Merged
merged 2 commits into from
Sep 21, 2024

Conversation

jonobr1
Copy link
Owner

@jonobr1 jonobr1 commented Sep 21, 2024

Because Two.js uses Canvas2D texture uploads to create its shapes, negative scale values yield blank a blank canvas to send to the GPU. This fixes that by ensuring the underlying path.renderer.scale property is always positive.

@jonobr1 jonobr1 merged commit 6b2684a into dev Sep 21, 2024
1 check passed
@jonobr1 jonobr1 deleted the 736-webgl-negative-scale branch September 21, 2024 04:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant