Skip to content

Commit

Permalink
[4.4] Improve translation of aria label text by extra language keys (#…
Browse files Browse the repository at this point in the history
…44050)

* Improve translation of aria label text by extra language keys

* Update layouts/joomla/pagination/link.php

Co-authored-by: jsanders <[email protected]>

* Update layouts/joomla/pagination/link.php

Co-authored-by: jsanders <[email protected]>

* Update layouts/joomla/pagination/link.php

Co-authored-by: jsanders <[email protected]>

* Update layouts/joomla/pagination/link.php

Co-authored-by: jsanders <[email protected]>

---------

Co-authored-by: jsanders <[email protected]>
Co-authored-by: Quy <[email protected]>
  • Loading branch information
3 people authored Sep 11, 2024
1 parent 02442d9 commit 94d9664
Show file tree
Hide file tree
Showing 3 changed files with 12 additions and 5 deletions.
4 changes: 4 additions & 0 deletions administrator/language/en-GB/lib_joomla.ini
Original file line number Diff line number Diff line change
Expand Up @@ -444,6 +444,10 @@ JLIB_HTML_FEATURED_PENDING_ITEM="Featured, but is Pending."
JLIB_HTML_FEATURED_STARTED="Start: %s"
JLIB_HTML_GOTO_PAGE="Go to page %s"
JLIB_HTML_GOTO_POSITION="Go to %s page"
JLIB_HTML_GOTO_POSITION_END="Go to last page"
JLIB_HTML_GOTO_POSITION_NEXT="Go to next page"
JLIB_HTML_GOTO_POSITION_PREVIOUS="Go to previous page"
JLIB_HTML_GOTO_POSITION_START="Go to first page"
JLIB_HTML_ITEM_PUBLISHED_BUT_CATEGORY_TRASHED="Published but the category is trashed."
JLIB_HTML_ITEM_PUBLISHED_BUT_CATEGORY_UNPUBLISHED="Published but the category is not published."
JLIB_HTML_MOVE_DOWN="Move Down"
Expand Down
4 changes: 4 additions & 0 deletions language/en-GB/lib_joomla.ini
Original file line number Diff line number Diff line change
Expand Up @@ -443,6 +443,10 @@ JLIB_HTML_FEATURED_PENDING_ITEM="Featured, but is Pending."
JLIB_HTML_FEATURED_STARTED="Start: %s"
JLIB_HTML_GOTO_PAGE="Go to page %s"
JLIB_HTML_GOTO_POSITION="Go to %s page"
JLIB_HTML_GOTO_POSITION_END="Go to last page"
JLIB_HTML_GOTO_POSITION_NEXT="Go to next page"
JLIB_HTML_GOTO_POSITION_PREVIOUS="Go to previous page"
JLIB_HTML_GOTO_POSITION_START="Go to first page"
JLIB_HTML_MOVE_DOWN="Move Down"
JLIB_HTML_MOVE_UP="Move Up"
JLIB_HTML_NO_PARAMETERS_FOR_THIS_ITEM="There are no parameters for this item."
Expand Down
9 changes: 4 additions & 5 deletions layouts/joomla/pagination/link.php
Original file line number Diff line number Diff line change
Expand Up @@ -21,26 +21,25 @@
// Check for "Start" item
case Text::_('JLIB_HTML_START'):
$icon = $app->getLanguage()->isRtl() ? 'icon-angle-double-right' : 'icon-angle-double-left';
$aria = Text::sprintf('JLIB_HTML_GOTO_POSITION', strtolower($item->text));
$aria = Text::_('JLIB_HTML_GOTO_POSITION_START');
break;

// Check for "Prev" item
case $item->text === Text::_('JPREV'):
$item->text = Text::_('JPREVIOUS');
$icon = $app->getLanguage()->isRtl() ? 'icon-angle-right' : 'icon-angle-left';
$aria = Text::sprintf('JLIB_HTML_GOTO_POSITION', strtolower($item->text));
$aria = Text::_('JLIB_HTML_GOTO_POSITION_PREVIOUS');
break;

// Check for "Next" item
case Text::_('JNEXT'):
$icon = $app->getLanguage()->isRtl() ? 'icon-angle-left' : 'icon-angle-right';
$aria = Text::sprintf('JLIB_HTML_GOTO_POSITION', strtolower($item->text));
$aria = Text::_('JLIB_HTML_GOTO_POSITION_NEXT');
break;

// Check for "End" item
case Text::_('JLIB_HTML_END'):
$icon = $app->getLanguage()->isRtl() ? 'icon-angle-double-left' : 'icon-angle-double-right';
$aria = Text::sprintf('JLIB_HTML_GOTO_POSITION', strtolower($item->text));
$aria = Text::_('JLIB_HTML_GOTO_POSITION_END');
break;

default:
Expand Down

0 comments on commit 94d9664

Please sign in to comment.