-
-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Made items in the media tree of media manager keyboard accessible #37152
Conversation
Please read #35911 (comment). |
so should I close the PR??? |
Please read the comment and try to fix it as the other PR is not the correct fix. |
okay
I added the feature to open the media-tree folders using enter key, is it necessary to make them navigable using arrow keys because we do the same using tab and move up using shift + tab |
Please see #35911 (comment) |
c6840da
to
1f6113a
Compare
I have tested this item 🔴 unsuccessfully on b877bea
That change doesnt work at all - the enter key does nothing. And as stated before by @Quy please review the previous comments This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37152. |
to open a node in the tree you now have to use the right arrow key, because it was mentioned in the comments of the PR #35911 |
Please update the testing instructions accordingly |
done |
Closing in favor of #38126. Thank you. |
Pull Request for Issue #37117.
Summary of Changes
solved the first issue from the issue #37117, i.e. made the items in the media tree of the media manager, keyboard accessible
Testing Instructions
open the media manger of Joomla-CMS then click in the media tree section and press tab key
Press the right arrow key on any node to open it
Actual result BEFORE applying this Pull Request
You were not able to access any item of the media tree section using tab key
Expected result AFTER applying this Pull Request
You are able to access each item of the media tree section using tab key
Documentation Changes Required
No changes required.