Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Made items in the media tree of media manager keyboard accessible #37152

Closed
wants to merge 2 commits into from

Conversation

akshitrattan
Copy link

@akshitrattan akshitrattan commented Feb 26, 2022

Pull Request for Issue #37117.

Summary of Changes

solved the first issue from the issue #37117, i.e. made the items in the media tree of the media manager, keyboard accessible

Testing Instructions

open the media manger of Joomla-CMS then click in the media tree section and press tab key
Press the right arrow key on any node to open it

Actual result BEFORE applying this Pull Request

You were not able to access any item of the media tree section using tab key

Expected result AFTER applying this Pull Request

You are able to access each item of the media tree section using tab key

Screenshot 2022-02-26 at 8 48 04 PM

Documentation Changes Required

No changes required.

@joomla-cms-bot joomla-cms-bot added NPM Resource Changed This Pull Request can't be tested by Patchtester PR-4.1-dev labels Feb 26, 2022
@Quy
Copy link
Contributor

Quy commented Feb 26, 2022

Please read #35911 (comment).

@akshitrattan
Copy link
Author

Related #35911

so should I close the PR???

@Quy
Copy link
Contributor

Quy commented Feb 26, 2022

Please read the comment and try to fix it as the other PR is not the correct fix.

@akshitrattan
Copy link
Author

Please read the comment and try to fix it as the other PR is not the correct fix.

okay

Please read the comment and try to fix it as the other PR is not the correct fix.

I added the feature to open the media-tree folders using enter key, is it necessary to make them navigable using arrow keys because we do the same using tab and move up using shift + tab

@Quy
Copy link
Contributor

Quy commented Feb 26, 2022

Please see #35911 (comment)

@brianteeman
Copy link
Contributor

I have tested this item 🔴 unsuccessfully on b877bea

Now it is impossible to reach the tree at all using the keyboard :(

I added the feature to open the media-tree folders using enter key

That change doesnt work at all - the enter key does nothing.

And as stated before by @Quy please review the previous comments


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37152.

@akshitrattan
Copy link
Author

akshitrattan commented Mar 1, 2022

I have tested this item 🔴 unsuccessfully on b877beaNow it is impossible to reach the tree at all using the keyboard :(

I added the feature to open the media-tree folders using enter key

That change doesnt work at all - the enter key does nothing.

And as stated before by @Quy please review the previous comments

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37152.

to open a node in the tree you now have to use the right arrow key, because it was mentioned in the comments of the PR #35911

@drmenzelit
Copy link
Contributor

to open a node in the tree you now have to use the right arrow key, because it was mentioned in the comments of the PR #35911

Please update the testing instructions accordingly

@akshitrattan
Copy link
Author

to open a node in the tree you now have to use the right arrow key, because it was mentioned in the comments of the PR #35911

Please update the testing instructions accordingly

done

@drmenzelit drmenzelit added the a11y Accessibility label Mar 10, 2022
@akshitrattan
Copy link
Author

Screenshot 2022-03-13 at 12 52 52 PM

I added these lines of code for using the arrowkeys to navigate through the media-tree but I'm not able to make it work any suggestions would be really helpful

@Quy
Copy link
Contributor

Quy commented Jun 22, 2022

Closing in favor of #38126. Thank you.

@Quy Quy closed this Jun 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a11y Accessibility NPM Resource Changed This Pull Request can't be tested by Patchtester
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants