Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[4.4] [BUGFIX] Enforce UTF-8 on CSS Files #42938

Merged
merged 1 commit into from
Mar 11, 2024

Conversation

dgrammatiko
Copy link
Contributor

@dgrammatiko dgrammatiko commented Mar 2, 2024

Pull Request for Issue #42611 .

Summary of Changes

Adds @charset "UTF-8"; as a first line on all the CSS files. Docs: https://developer.mozilla.org/en-US/docs/Web/CSS/@charset

Testing Instructions

  • Ensure your browser default encoding IS NOT UTF-8
  • Download and install Joomla from this Pull Request
  • Check that icons don't get weird...

Actual result BEFORE applying this Pull Request

Expected result AFTER applying this Pull Request

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

@brianteeman
Copy link
Contributor

Ensure your browser default encoding IS NOT UTF-8

How?

@dgrammatiko
Copy link
Contributor Author

How?

Turns out only safari allows changing the default encoding. FF and Chrome do not expose this setting anymore

@richard67 richard67 added the bug label Mar 3, 2024
@Fedik
Copy link
Member

Fedik commented Mar 11, 2024

I have tested this item ✅ successfully on ec1e092

with utf-8 better than without :)


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42938.

@viocassel
Copy link
Contributor

I have tested this item ✅ successfully on ec1e092


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42938.

@Quy Quy removed the bug label Mar 11, 2024
@Quy
Copy link
Contributor

Quy commented Mar 11, 2024

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42938.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Mar 11, 2024
@laoneo laoneo merged commit 49f392d into joomla:4.4-dev Mar 11, 2024
4 checks passed
@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Mar 11, 2024
@laoneo
Copy link
Member

laoneo commented Mar 11, 2024

Thanks!

@laoneo laoneo added this to the Joomla! 4.4.4 milestone Mar 11, 2024
@dgrammatiko dgrammatiko deleted the 4.4-dev-fa-icons-utf branch March 12, 2024 06:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants