Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[5.2] Fix Dart Sass deprecations #44129

Open
wants to merge 3 commits into
base: 5.2-dev
Choose a base branch
from

Conversation

C-Lodder
Copy link
Member

Summary of Changes

lighten() and darken() are global functions in Dart Sass, that were deprecated as of v1.79.0.
This PR replaces them with color.adjust() inside Joomla's SCSS

Note: Bootstrap's own SCSS still uses these functions, and may or may not fix said deprecations in v5, due to the fact they still support node-sass.

Testing Instructions

Code review

@joomla-cms-bot joomla-cms-bot added NPM Resource Changed This Pull Request can't be tested by Patchtester PR-5.2-dev labels Sep 24, 2024
@Quy
Copy link
Contributor

Quy commented Sep 26, 2024

I have tested this item ✅ successfully on e22174c


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44129.

1 similar comment
@viocassel
Copy link
Contributor

I have tested this item ✅ successfully on e22174c


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44129.

@alikon
Copy link
Contributor

alikon commented Sep 28, 2024

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44129.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Sep 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
NPM Resource Changed This Pull Request can't be tested by Patchtester PR-5.2-dev RTC This Pull Request is Ready To Commit
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants