[5.3] Customfields: Also look at context when checking uniqueness #44161
+1
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request for Issue #44154 .
Summary of Changes
Customfields should only be uniquely named per context, so you should be able to have a field
test
in both articles and users. So far this is prohibited and you can only name a field uniquely system wide. This PR should fix that.Testing Instructions
Create a customfield with name
test
in articles and in users.Actual result BEFORE applying this Pull Request
Creating the second field is denied.
Expected result AFTER applying this Pull Request
Both fields can be saved.
Link to documentations
Please select:
Documentation link for docs.joomla.org:
No documentation changes for docs.joomla.org needed
Pull Request link for manual.joomla.org:
No documentation changes for manual.joomla.org needed