Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[6.0] Delete 5.2.0 update SQL scripts and add them to deleted files in script.php #44188

Open
wants to merge 4 commits into
base: 6.0-dev
Choose a base branch
from

Conversation

richard67
Copy link
Member

@richard67 richard67 commented Oct 3, 2024

Pull Request for Issue # .

Summary of Changes

See title.

The update SQL scripts handled with this PR were included in the upmerge PR #44059 from September 12.

Normally they should not be merged up, and adding them to the deleted files list in script.php is done by me regularly.

This PR removes these (for each database type 3) update SQL scripts and adds them to the deleted files list in script.php.

In addition, the update SQL scripts 5.2.0-2024-09-17.sql which have not been merged up are added to the deleted files list in script.php, too.

Testing Instructions

Code review.

Ping @Bodge-IT @softforge .

Actual result BEFORE applying this Pull Request

A 6.0-dev build includes 5.2.0 update SQL scripts and doesn't delete them on update from 5.3 (or in future 5.4)

Expected result AFTER applying this Pull Request

A 6.0-dev build doesn't include any 5.2.0 update SQL scripts and deletes them on update from 5.3 (or in future 5.4)

Link to documentations

Please select:

  • No documentation changes for docs.joomla.org needed

  • No documentation changes for manual.joomla.org needed

@richard67 richard67 changed the title [6.0] Delete 5.2.0 update SL scripts and add them to deleted files in scipt.php [6.0] Delete 5.2.0 update SQL scripts and add them to deleted files in scipt.php Oct 3, 2024
@Bodge-IT Bodge-IT changed the title [6.0] Delete 5.2.0 update SQL scripts and add them to deleted files in scipt.php [6.0] Delete 5.2.0 update SQL scripts and add them to deleted files in script.php Oct 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants