[5.2] phpcs comments / use statements

[heelc29]

Summary of Changes

• move use statements out of phpcs disable area
• fix phpcs:enable identifier

Testing Instructions

code review

[Quy]

I have tested this item ✅ successfully on 0c6ea05

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44194.}

[richard67]

I have tested this item ✅ successfully on 0c6ea05

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44194.}

[richard67]

RTC

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44194.}

[brianteeman]

are we sure we even need to disable phpcs for this? There are a lot of instances where it is not disabled

eg

joomla-cms/administrator/components/com_cpanel/services/provider.php

Lines 7 to 13 in 23c750a

	* @copyright (C) 2018 Open Source Matters, Inc. <https://www.joomla.org>
	* @license GNU General Public License version 2 or later; see LICENSE.txt
	*/
	\defined('_JEXEC') or die;
	use Joomla\CMS\Dispatcher\ComponentDispatcherFactoryInterface;

[richard67]

are we sure we even need to disable phpcs for this? There are a lot of instances where it is not disabled

@brianteeman It is needed when in that file a function is defined or a class. PHPCS say then that you shall not have both in the same file, a statement with side effects like the defined, and definition of a symbol.

In your example it is not needed because the function definitions are wrapped into an anonymous class.

[brianteeman]

@richard67 Thanks you for the explanation