5.2 dev Fix breadcrumbs color in light and darkmode, fix for 44134 #44212
+5
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
coolcat-creations
requested review from
laoneo,
chmst,
bembelimen,
HLeithner,
rdeutz and
Hackwar
as code owners
|
I have tested this item ✅ successfully on b62a2c6 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44212. |
|
Almost but not quite. The text is now visible but the border is still invisible
|
|
Shouldn't the border be rather removed in dark? It's the last item |
joomla-cms-bot
added
NPM Resource Changed
|
I removed the border from the last item generally because the border is shaped like an arrow and implies that something on the right of it is not visible |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request for Issue #44134 .
Summary of Changes
Assiged body color to the last item of breadcrumbs
Testing Instructions
Download the test package
Navigate to media manager
navigate into a deeper folder
Actual result BEFORE applying this Pull Request
Expected result AFTER applying this Pull Request
Link to documentations
Please select:
Documentation link for docs.joomla.org:
[ x] No documentation changes for docs.joomla.org needed
Pull Request link for manual.joomla.org:
[ x] No documentation changes for manual.joomla.org needed