[5.2] Fix unescaped slashes break markup in script tag #44717
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the below change, slashes in markup, added as script option, are no longer correctly escaped.
3392240
#41330
Please also see: https://www.w3.org/TR/REC-html40/appendix/notes.html#h-B.3.2
Summary of Changes
Remove the
JSON_UNESCAPED_SLASHES
flag.Testing Instructions
Add the following code to any controller action. e.g. DisplayController::display() in
administrator/components/com_content/src/Controller/
\Joomla\CMS\Factory::getApplication()->getDocument()->addScriptOptions('test', '</script>');
Browse to the corresponding page.
Actual result BEFORE applying this Pull Request
It will break the resulting markup, because the slash in
</script>
is not escaped.Expected result AFTER applying this Pull Request
The resulting markup correctly escapes the slash in
</script>
.Link to documentations
Please select:
Documentation link for docs.joomla.org:
No documentation changes for docs.joomla.org needed
Pull Request link for manual.joomla.org:
No documentation changes for manual.joomla.org needed